feat: add custom status readers #314
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| // ReadStatus reads the object identified by the passed-in identifier and computes it's status. It reads | ||
| // the resource here, but computing status is delegated to the ReadStatusForObject function. | ||
| func (b *baseStatusReader) ReadStatus(ctx context.Context, reader engine.ClusterReader, identifier object.ObjMetadata) (*event.ResourceStatus, error) { | ||
| object, err := b.lookupResource(ctx, reader, identifier) |
There was a problem hiding this comment.
why is this lookup needed? If it's needed that's ultimately fine, but seems like the unstructured resource should have been available and could have been avoided.
There was a problem hiding this comment.
It resolves the GroupKindVersion for the given identifier and check if the resource exists
| deployment *unstructured.Unstructured) (*event.ResourceStatus, error) { | ||
| identifier := object.UnstructuredToObjMetadata(deployment) | ||
|
|
||
| res, err := status.Compute(deployment) |
There was a problem hiding this comment.
isn't the code that lists the pods w/in kstatus? I would assume this just means we'll execute it by delegating to it.
There was a problem hiding this comment.
This code looks at the properties that are available on all or most of the Kubernetes resources (like: .status.currentReplicas, .status.replicas etc.). I got rid of the code for checking the Pod's status. It checks only the main resource type
Get status directly from the Deployment, ReplicaSet and StatefulSet objects